commit e71d570bb84a80c9543e0797c0a9bf2082ac88f5
author Eric Laurent <elaurent@google.com> Fri Sep 07 11:56:12 2012 -0700
committer Android (Google) Code Review <android-gerrit@google.com> Fri Sep 07 15:29:53 2012 -0700
tree 2f6e2f2ab56eabee3a21f5329f1b469711df651b
parent ebfe9d02235aef98a62ad7b1bbf9c13c040651d5

audio: fix string leakage in out_get_parameters()

out_get_parameters() was calling strdup() on the string
returned by str_parms_to_str() before returning it
to the caller. This creates a new string which is never freed
as str_parms_to_str() already allocates a new string.

Change-Id: I4bcc4aa17ab55e830d7a0569151f717422f6459b

audio/audio_hw.c

diff --git a/audio/audio_hw.c b/audio/audio_hw.c
index 5b5e03e..4206893 100644
--- a/audio/audio_hw.c
+++ b/audio/audio_hw.c
@@ -1877,7 +1877,7 @@
             i++;
         }
         str_parms_add_str(reply, AUDIO_PARAMETER_STREAM_SUP_CHANNELS, value);
-        str = strdup(str_parms_to_str(reply));
+        str = str_parms_to_str(reply);
     } else {
         str = strdup(keys);
     }