commit 720a650f8ab3166d32fc5da64961e8d2158b9452
author Herbert Xu <herbert@gondor.apana.org.au> Fri Sep 28 09:06:11 2007 +0800
committer David S. Miller <davem@sunset.davemloft.net> Wed Oct 10 16:55:45 2007 -0700
tree 87676471c8550ec09935982a910bda5454928d92
parent f19f5111c94053ba4931892f5c01c806de33942e

[CRYPTO] cryptomgr: Fix parsing of recursive algorithms

As Joy Latten points out, inner algorithm parameters will miss the closing
bracket which will also cause the outer algorithm to terminate prematurely.

This patch fixes that also kills the WARN_ON if the number of parameters
exceed the maximum as that is a user error.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

crypto/cryptomgr.c

diff --git a/crypto/cryptomgr.c b/crypto/cryptomgr.c
index c83884f..e5e3cf8 100644
--- a/crypto/cryptomgr.c
+++ b/crypto/cryptomgr.c
@@ -129,6 +129,7 @@
 			}
 
 			notnum = 1;
+			p++;
 		}
 
 		len = p - name;
@@ -151,7 +152,7 @@
 		param->tb[i + 1] = &param->attrs[i].attr;
 		i++;
 
-		if (WARN_ON(i >= CRYPTO_MAX_ATTRS))
+		if (i >= CRYPTO_MAX_ATTRS)
 			goto err_free_param;
 
 		if (*p == ')')