commit 3c0e8e2aefca4b74e6d387118c67b7bbe3622001
author Alexandros Frantzis <alexandros.frantzis@canonical.com> Sat Dec 15 11:46:12 2012 +0200
committer Alexandros Frantzis <alexandros.frantzis@canonical.com> Sat Dec 15 11:46:12 2012 +0200
tree dff68986e2dfe9027a6b019c9f9d5498a6399456
parent 6f808b75d48e5c8ed98fd103098a677ca9ce2e9b

SceneRefract: Fix potential memory leak

The memory leak occurs when using the scene for multiple benchmarks.

src/scene-refract.cpp

diff --git a/src/scene-refract.cpp b/src/scene-refract.cpp
index b936362..db0aec8 100644
--- a/src/scene-refract.cpp
+++ b/src/scene-refract.cpp
@@ -87,11 +87,6 @@
                                            "false,true");
 }
 
-SceneRefract::~SceneRefract()
-{
-    delete priv_;
-}
-
 bool
 SceneRefract::supported(bool show_errors)
 {
@@ -150,6 +145,7 @@
 {
     // Add scene-specific teardown here
     priv_->teardown();
+    delete priv_;
     Scene::teardown();
 }
 

src/scene.h

diff --git a/src/scene.h b/src/scene.h
index 88f839d..66377e1 100644
--- a/src/scene.h
+++ b/src/scene.h
@@ -580,7 +580,6 @@
     RefractPrivate* priv_;
 public:
     SceneRefract(Canvas& canvas);
-    ~SceneRefract();
     bool supported(bool show_errors);
     bool load();
     void unload();