commit ca4c6948f69f807967f91d0e995716dd0f421dc5
author claireho <chinglanho@gmail.com> Tue Jan 18 16:00:12 2011 -0800
committer claireho <chinglanho@gmail.com> Tue Jan 18 16:07:56 2011 -0800
tree 2c7da25afe5d24b9fa59a8fcd026f12f64f26d12
parent 57e6107a9d66a9a97b146def0ef38c010f954be6

Bug 3204605: Hebrew Diacritics rendering problem.

Problem: Non-spacing Hebrew discritics is rendered as a spacing
character(base char) instead of positioned to last precediding
base character.
This is a new bug after sync to latest Harfbuzz.old library.
Reverted to the older version of harfbuzz-hebrew.c

Change-Id: I7e9cc5296fdfb0654ab1eeccfce960a3c2ffa5f0

src/harfbuzz-hebrew.c

diff --git a/src/harfbuzz-hebrew.c b/src/harfbuzz-hebrew.c
index 67029be..b5431a5 100755
--- a/src/harfbuzz-hebrew.c
+++ b/src/harfbuzz-hebrew.c
@@ -84,7 +84,7 @@
         logClusters[0] = 0;
 
         for (i = 1; i < shaper_item->item.length; ++i) {
-            hb_uint16 base = shapedChars[slen-1];
+            hb_uint16 base = shapedChars[cluster_start];
             hb_uint16 shaped = 0;
             HB_Bool invalid = FALSE;
             if (uc[i] == Dagesh) {
@@ -143,7 +143,7 @@
             }
             if (shaped) {
                 if (shaper_item->font->klass->canRender(shaper_item->font, (HB_UChar16 *)&shaped, 1)) {
-                    shapedChars[slen-1] = shaped;
+                    shapedChars[cluster_start] = shaped;
                 } else
                     shaped = 0;
             }