commit 326aed4d218c75815abf7038bc4e6c349d899bae
author Jean-Baptiste Queru <jbq@google.com> Sun Nov 15 12:06:00 2009 -0800
committer Jean-Baptiste Queru <jbq@google.com> Sun Nov 15 12:06:00 2009 -0800
tree a2e42e33ca1c1948e1fb20a74547284e03899124
parent a86466860fb5fec2fe93e280e05c523f3157540f
parent 78c0fc9f82ef48ac90c3c717b0fecdb21643047c

merge from eclair

l2tp.c

diff --git a/l2tp.c b/l2tp.c
index 10fc045..8d46e1b 100644
--- a/l2tp.c
+++ b/l2tp.c
@@ -33,8 +33,6 @@
 
 #include "mtpd.h"
 
-/* TODO: Support secrets. */
-
 /* To avoid unnecessary endianness conversions, tunnels, sessions, attributes,
  * and values are all accessed in network order. */
 

mtpd.c

diff --git a/mtpd.c b/mtpd.c
index ed03fcf..55f1a55 100644
--- a/mtpd.c
+++ b/mtpd.c
@@ -150,13 +150,16 @@
     /* L2TP secret is the only thing stored in keystore. We do the query here
      * so other files are clean and free from android specific code. */
     if (i > 4 && !strcmp("l2tp", args[1]) && args[4][0]) {
-        char *value = keystore_get(args[4], NULL);
-        if (!value) {
+        char value[KEYSTORE_MESSAGE_SIZE];
+        int length = keystore_get(args[4], value);
+        if (length == -1) {
             log_print(FATAL, "Cannot get L2TP secret from keystore");
             exit(SYSTEM_ERROR);
         }
         free(args[4]);
-        args[4] = value;
+        args[4] = malloc(length + 1);
+        memcpy(args[4], value, length);
+        args[4][length] = 0;
     }
 
     *argc = i;