commit 4328d3947562a17ab929b0ac2bfe67497f9e1d07
author Greg Hackmann <ghackmann@google.com> Mon Dec 10 15:28:45 2012 -0800
committer Greg Hackmann <ghackmann@google.com> Tue Jan 08 15:07:42 2013 -0800
tree 2b309f33916fffb085885dec8699babdbce35d9f
parent 129f353cd0597f7acd05097f4bca0b3c5890dc23

csc: handle Gscaler errors

Change-Id: I75f0d0966e9f7ef10068645df0f41fa6b837c517
Signed-off-by: Greg Hackmann <ghackmann@google.com>

libcsc/csc.c

diff --git a/libcsc/csc.c b/libcsc/csc.c
index 409391a..ddb4541 100644
--- a/libcsc/csc.c
+++ b/libcsc/csc.c
@@ -363,8 +363,7 @@
     if (csc_handle->csc_method == CSC_METHOD_HW) {
         if (csc_handle->csc_hw_handle == NULL) {
             ALOGE("%s:: CSC_METHOD_HW can't open HW", __func__);
-            free(csc_handle);
-            csc_handle = NULL;
+            ret = CSC_Error;
         }
     }
 
@@ -711,11 +710,19 @@
         return CSC_ErrorNotInit;
 
     if ((csc_handle->csc_method == CSC_METHOD_HW) &&
-        (csc_handle->csc_hw_handle == NULL))
-        csc_init_hw(handle);
+        (csc_handle->csc_hw_handle == NULL)) {
+        ret = csc_init_hw(handle);
+        if (ret != CSC_ErrorNone)
+            return ret;
+    }
 
-    csc_set_format(csc_handle);
-    csc_set_buffer(csc_handle);
+    ret = csc_set_format(csc_handle);
+    if (ret != CSC_ErrorNone)
+        return ret;
+
+    ret = csc_set_buffer(csc_handle);
+    if (ret != CSC_ErrorNone)
+        return ret;
 
     if (csc_handle->csc_method == CSC_METHOD_HW)
         ret = conv_hw(csc_handle);