jniRegisterNativeMethods should abort on failure
The jniRegisterNativeMethods function currently behaves like the
RegisterNatives function that it wraps, returning 0 on success and
nonzero on failure. However, this is an internal-only function used
by bits of infrastructure that should never fail to initialize. By
aborting sooner we make the failure impossible to ignore.
This doesn't appear to break anything.
Bug 3323089
Change-Id: I48d1b02d90616d4c9ee01eb0e46cb61752727c5b
diff --git a/JNIHelp.c b/JNIHelp.c
index 59d457b..ededb4c 100644
--- a/JNIHelp.c
+++ b/JNIHelp.c
@@ -37,18 +37,18 @@
LOGV("Registering %s natives\n", className);
clazz = (*env)->FindClass(env, className);
if (clazz == NULL) {
- LOGE("Native registration unable to find class '%s'\n", className);
- return -1;
+ LOGE("Native registration unable to find class '%s', aborting\n",
+ className);
+ abort();
}
- int result = 0;
if ((*env)->RegisterNatives(env, clazz, gMethods, numMethods) < 0) {
- LOGE("RegisterNatives failed for '%s'\n", className);
- result = -1;
+ LOGE("RegisterNatives failed for '%s', aborting\n", className);
+ abort();
}
(*env)->DeleteLocalRef(env, clazz);
- return result;
+ return 0;
}
/*
