tree 65c37e48d5ba303a54c4686ea22304ae871b7a6d
parent 53b834a8a7f9f077ff751ade222d2f81d9d6fdad
author Matthew Xie <mattx@google.com> 1332190457 -0700
committer Android (Google) Code Review <android-gerrit@google.com> 1342500586 -0700

Revert "fix persistent audio on, Donot connect_audio when enter CONNECTED state"

This reverts commit 3ce52a01d734e73a21074ab8397cf67b16d6595f

Hi Matt,
I reviewed your changes (2), and they look good. However, your changes in (1), seem to be causing a side-effect while testing the headset connection setup while call is active/outgoing/incoming. Since this change was merged, I am sending my comments thru email.
Here is the scenario
1.       No headset connection

2.       Place an outgoing call, and answer it at the remote side

3.       Initiate connection from headset

4.       SCO seems to be setup by Java side even before SLC setup completes

ISSUE#1: Once Java receives connection event, it automatically calls connect_audio, even though SLC has not been setup
ð  Can you make a change to call connect_audio, only after SLC is complete? If this difficult to do, can this code just be removed, as the stack will do automatically after SLC setup when phone_state_change is called

ISSUE#2: If we redo this for an outgoing call (call answered prior to headset connection), then the Java side does not initiate SCO audio
ð  To have a consistent behavior, if Java side is setting up SCO for active call, shouldn’t we be doing the same for outgoing call too?

Thanks
Ravi