commit 5e794499725296c2d436ccbe54e5517037938172
author Jean-Baptiste Queru <jbq@google.com> Mon Feb 13 14:22:28 2012 -0800
committer android code review <noreply-gerritcodereview@google.com> Mon Feb 13 14:22:29 2012 -0800
tree 9bd43992810485131d62a62d292d3904d6a080bf
parent 72a7041136b14e4ee98d3e53837c7dff6d54402b
parent 885c0a68bb4a91d461914c43c2e42a565394aa59

Merge "Remove PKCS12_PASSWORD_DIALOG and NAME_CREDENTIAL_DIALOG in order to correctly recreate it on onCreateDialog"

src/com/android/certinstaller/CertInstaller.java

diff --git a/src/com/android/certinstaller/CertInstaller.java b/src/com/android/certinstaller/CertInstaller.java
index d37cd72..0809ad3 100644
--- a/src/com/android/certinstaller/CertInstaller.java
+++ b/src/com/android/certinstaller/CertInstaller.java
@@ -317,6 +317,10 @@
     private Dialog createPkcs12PasswordDialog() {
         View view = View.inflate(this, R.layout.password_dialog, null);
         mView.setView(view);
+        if (mView.getHasEmptyError()) {
+            mView.showError(R.string.password_empty_error);
+            mView.setHasEmptyError(false);
+        }
 
         String title = mCredentials.getName();
         title = TextUtils.isEmpty(title)
@@ -329,7 +333,8 @@
                     public void onClick(DialogInterface dialog, int id) {
                         String password = mView.getText(R.id.credential_password);
                         if (TextUtils.isEmpty(password)) {
-                            mView.showError(R.string.password_empty_error);
+                            mView.setHasEmptyError(true);
+                            removeDialog(PKCS12_PASSWORD_DIALOG);
                             showDialog(PKCS12_PASSWORD_DIALOG);
                         } else {
                             mNextAction = new Pkcs12ExtractAction(password);
@@ -354,6 +359,10 @@
     private Dialog createNameCredentialDialog() {
         ViewGroup view = (ViewGroup) View.inflate(this, R.layout.name_credential_dialog, null);
         mView.setView(view);
+        if (mView.getHasEmptyError()) {
+            mView.showError(R.string.name_empty_error);
+            mView.setHasEmptyError(false);
+        }
         mView.setText(R.id.credential_info, mCredentials.getDescription(this).toString());
         final EditText nameInput = (EditText) view.findViewById(R.id.credential_name);
         nameInput.setText(getDefaultName());
@@ -365,7 +374,8 @@
                     public void onClick(DialogInterface dialog, int id) {
                         String name = mView.getText(R.id.credential_name);
                         if (TextUtils.isEmpty(name)) {
-                            mView.showError(R.string.name_empty_error);
+                            mView.setHasEmptyError(true);
+                            removeDialog(NAME_CREDENTIAL_DIALOG);
                             showDialog(NAME_CREDENTIAL_DIALOG);
                         } else {
                             removeDialog(NAME_CREDENTIAL_DIALOG);

src/com/android/certinstaller/ViewHelper.java

diff --git a/src/com/android/certinstaller/ViewHelper.java b/src/com/android/certinstaller/ViewHelper.java
index 81ff628..6561667 100644
--- a/src/com/android/certinstaller/ViewHelper.java
+++ b/src/com/android/certinstaller/ViewHelper.java
@@ -24,6 +24,7 @@
  */
 class ViewHelper {
     private View mView;
+    private boolean mHasEmptyError;
 
     void setView(View view) {
         mView = view;
@@ -49,4 +50,12 @@
         TextView v = (TextView) mView.findViewById(viewId);
         if (v != null) v.setText(textId);
     }
+
+    void setHasEmptyError(boolean hasEmptyError) {
+        mHasEmptyError = hasEmptyError;
+    }
+
+    boolean getHasEmptyError() {
+        return mHasEmptyError;
+    }
 }