commit 81a0690f93c021e189976a476c20fc5aab4841a5
author Isaac Katzenelson <isaack@android.com> Fri Feb 08 11:40:57 2013 -0800
committer Isaac Katzenelson <isaack@android.com> Fri Feb 08 12:01:14 2013 -0800
tree b59d6a750d1a45eca77e6be2143fc9668d50fece
parent a3458d9448c4131b530361fb87edb28baebb647e

Resseting volume button to "do nothing" on upgrade

Bug:8151863

Change-Id: Ic99172767f90d78837f783336309f9a99bfd3ea2

src/com/android/deskclock/AlarmInitReceiver.java

diff --git a/src/com/android/deskclock/AlarmInitReceiver.java b/src/com/android/deskclock/AlarmInitReceiver.java
index 1dd7bb3..b2625f1 100644
--- a/src/com/android/deskclock/AlarmInitReceiver.java
+++ b/src/com/android/deskclock/AlarmInitReceiver.java
@@ -58,7 +58,7 @@
 
                     if (!prefs.getBoolean(PREF_VOLUME_DEF_DONE, false)) {
                         // Fix the default
-                        Log.v("AlarmInitReceiver - checking volume button default");
+                        Log.v("AlarmInitReceiver - resetting volume button default");
                         switchVolumeButtonDefault(prefs);
                     }
                 }
@@ -73,17 +73,8 @@
     private void switchVolumeButtonDefault(SharedPreferences prefs) {
         SharedPreferences.Editor editor = prefs.edit();
 
-        // Get the volume button behavior setting
-        final String vol = prefs.getString(SettingsActivity.KEY_VOLUME_BEHAVIOR,
-	        SettingsActivity.DEFAULT_VOLUME_BEHAVIOR);
-        // If the setting is "Snooze", change it to "Do Nothing"
-        if (SettingsActivity.OLD_DEFAULT_VOLUME_BEHAVIOR.equals(vol)) {
-                editor.putString(SettingsActivity.KEY_VOLUME_BEHAVIOR,
-                    SettingsActivity.DEFAULT_VOLUME_BEHAVIOR);
-            Log.v("AlarmInitReceiver - Reset volume button default");
-        } else {
-            Log.v("AlarmInitReceiver - No need to reset volume button default");
-        }
+        editor.putString(SettingsActivity.KEY_VOLUME_BEHAVIOR,
+            SettingsActivity.DEFAULT_VOLUME_BEHAVIOR);
 
         // Make sure we do it only once
         editor.putBoolean(PREF_VOLUME_DEF_DONE, true);

src/com/android/deskclock/SettingsActivity.java

diff --git a/src/com/android/deskclock/SettingsActivity.java b/src/com/android/deskclock/SettingsActivity.java
index 9465670..bafe95f 100644
--- a/src/com/android/deskclock/SettingsActivity.java
+++ b/src/com/android/deskclock/SettingsActivity.java
@@ -64,9 +64,7 @@
     static final String KEY_VOLUME_BUTTONS =
             "volume_button_setting";
 
-    // Old and new default preferences, needed to switch the default on upgrade
     public static final String DEFAULT_VOLUME_BEHAVIOR = "0";
-    public static final String OLD_DEFAULT_VOLUME_BEHAVIOR = "1";
 
     private static CharSequence[][] mTimezones;
     private long mTime;