commit f6017873e1056b0d9ec0932eb49af77f8ce8814c
author Sam Blitzstein <sblitz@google.com> Mon Jun 03 12:50:03 2013 -0700
committer Sam Blitzstein <sblitz@google.com> Mon Jun 03 16:23:59 2013 -0700
tree 57c194cd67f9aa13337202fe0fbe683d9ad7904a
parent a77d4702e88df72833de2f8913566305edaa10c4

Don't update timer notification unnecessarily.

Timer notification was updating itself while the timer was stopped.

Bug: 9248101
Change-Id: I585266e50dd8c54242b06e541d9b06cead6ab848

src/com/android/deskclock/timer/TimerReceiver.java

diff --git a/src/com/android/deskclock/timer/TimerReceiver.java b/src/com/android/deskclock/timer/TimerReceiver.java
index b0c6a6d..70eda98 100644
--- a/src/com/android/deskclock/timer/TimerReceiver.java
+++ b/src/com/android/deskclock/timer/TimerReceiver.java
@@ -190,12 +190,13 @@
         long now = Utils.getTimeNow();
         if (timersInUse.size() == 1) {
             TimerObj timer = timersInUse.get(0);
+            boolean timerIsTicking = timer.isTicking();
             String label = timer.mLabel.equals("") ?
                     context.getString(R.string.timer_notification_label) : timer.mLabel;
-            title = timer.isTicking() ? label : context.getString(R.string.timer_stopped);
-            long timeLeft = timer.isTicking() ? timer.getTimesupTime() - now : timer.mTimeLeft;
+            title = timerIsTicking ? label : context.getString(R.string.timer_stopped);
+            long timeLeft = timerIsTicking ? timer.getTimesupTime() - now : timer.mTimeLeft;
             contentText = buildTimeRemaining(context, timeLeft);
-            if (timeLeft > 60) {
+            if (timerIsTicking && timeLeft > 60 * 1000) {
                 nextBroadcastTime = getBroadcastTime(now, timeLeft);
             }
         } else {
@@ -213,7 +214,7 @@
                 long timeLeft = completionTime - now;
                 contentText = String.format(context.getString(R.string.next_timer_notif),
                         buildTimeRemaining(context, timeLeft));
-                if (timeLeft <= 60) {
+                if (timeLeft <= 60 * 1000) {
                     TimerObj timerWithUpdate = getNextRunningTimer(timersInUse, true, now);
                     if (timerWithUpdate != null) {
                         completionTime = timerWithUpdate.getTimesupTime();