commit 21cf95e716daac40f4da452f46f235b6b414dc12
author Tom Taylor <tomtaylor@google.com> Thu Feb 21 16:56:01 2013 -0800
committer Nick Kralevich <nnk@google.com> Fri Feb 22 09:19:04 2013 -0800
tree c0f013e2ebb85cd0f5adc02349335a3777052959
parent 0ffb2ddacbc0764a81a53f2636c07c39c78db131

Don't allow clients to update or insert _data column data

Bug 8214355

Change-Id: I45c93047ced465277a46c6a33d6ef590ab0bf8bb

src/com/android/providers/telephony/MmsProvider.java

diff --git a/src/com/android/providers/telephony/MmsProvider.java b/src/com/android/providers/telephony/MmsProvider.java
index bddce1d..3b17003 100644
--- a/src/com/android/providers/telephony/MmsProvider.java
+++ b/src/com/android/providers/telephony/MmsProvider.java
@@ -266,6 +266,10 @@
 
     @Override
     public Uri insert(Uri uri, ContentValues values) {
+        // Don't let anyone insert anything with the _data column
+        if (values != null && values.containsKey(Part._DATA)) {
+            return null;
+        }
         int msgBox = Mms.MESSAGE_BOX_ALL;
         boolean notify = true;
 
@@ -680,6 +684,10 @@
     @Override
     public int update(Uri uri, ContentValues values,
             String selection, String[] selectionArgs) {
+        // Don't let anyone update the _data column
+        if (values != null && values.containsKey(Part._DATA)) {
+            return 0;
+        }
         int match = sURLMatcher.match(uri);
         if (LOCAL_LOGV) {
             Log.v(TAG, "Update uri=" + uri + ", match=" + match);