commit 36a9e231e03734cd2143383d26388455c1764e17
author Kenny Root <kroot@google.com> Mon Feb 04 14:24:15 2013 -0800
committer Kenny Root <kroot@google.com> Mon Feb 04 14:33:05 2013 -0800
tree c078f5d058c473c91cfeb0b770e9b40df7a32a27
parent b51c47df67e67982dc3bff1efdf87fa048f7923f

Fix mtime via Binder

Change-Id: I3d5e3d4114d40902a6cf25a4c8ffabea4cc7851f

keystore/keystore.cpp

diff --git a/keystore/keystore.cpp b/keystore/keystore.cpp
index 2612325..98a8db6 100644
--- a/keystore/keystore.cpp
+++ b/keystore/keystore.cpp
@@ -1555,7 +1555,7 @@
         uid_t uid = IPCThreadState::self()->getCallingUid();
         if (!has_permission(uid, P_GET)) {
             ALOGW("permission denied for %d: getmtime", uid);
-            return ::PERMISSION_DENIED;
+            return -1L;
         }
         uid = get_keystore_euid(uid);
 
@@ -1565,22 +1565,25 @@
         encode_key_for_uid(filename, uid, name8);
 
         if (access(filename, R_OK) == -1) {
-            return (errno != ENOENT) ? ::SYSTEM_ERROR : ::KEY_NOT_FOUND;
+            ALOGW("could not access %s for getmtime", filename);
+            return -1L;
         }
 
         int fd = TEMP_FAILURE_RETRY(open(filename, O_NOFOLLOW, O_RDONLY));
         if (fd < 0) {
-            return ::SYSTEM_ERROR;
+            ALOGW("could not open %s for getmtime", filename);
+            return -1L;
         }
 
         struct stat s;
         int ret = fstat(fd, &s);
         close(fd);
         if (ret == -1) {
-            return ::SYSTEM_ERROR;
+            ALOGW("could not stat %s for getmtime", filename);
+            return -1L;
         }
 
-        return s.st_mtime;
+        return static_cast<int64_t>(s.st_mtime);
     }
 
 private: