commit ec2b0392adedaa2707b627b842f3f9f355d844d5
author Chia-chi Yeh <chiachi@android.com> Wed Jul 13 19:38:14 2011 -0700
committer Chia-chi Yeh <chiachi@android.com> Wed Jul 13 19:38:14 2011 -0700
tree 0441a16c0f7cd1e2f7a1f231f9ab6d5224b89353
parent ea299e6828421f15b1d23256527f2cd3668b9915

mtpd: update control protocol.

Change-Id: I38f6c524ed66a4ba1e5eb5d4cd6a6712e6e91e65

mtpd.c

diff --git a/mtpd.c b/mtpd.c
index 4943d1e..3c011f0 100644
--- a/mtpd.c
+++ b/mtpd.c
@@ -116,17 +116,17 @@
     args[0] = (*argv)[0];
     for (i = 1; i < 32; ++i) {
         unsigned char bytes[2];
-        if (recv(control, &bytes[0], 1, 0) != 1
-            || recv(control, &bytes[1], 1, 0) != 1) {
+        int length = recv(control, &bytes[0], 1, 0);
+
+        if (!length) {
+            break;
+        } else if (length != 1 || recv(control, &bytes[1], 1, 0) != 1) {
             log_print(FATAL, "Cannot get argument length");
             exit(SYSTEM_ERROR);
         } else {
-            int length = bytes[0] << 8 | bytes[1];
             int offset = 0;
+            length = bytes[0] << 8 | bytes[1];
 
-            if (length == 0xFFFF) {
-                break;
-            }
             args[i] = malloc(length + 1);
             while (offset < length) {
                 int n = recv(control, &args[i][offset], length - offset, 0);
@@ -190,7 +190,7 @@
             break;
         }
         timeout = pollfds[1].revents ?
-            the_protocol->process() : the_protocol->timeout();
+                the_protocol->process() : the_protocol->timeout();
     }
 
     if (timeout < 0) {
@@ -200,7 +200,7 @@
         read(signals[0], &signal, sizeof(int));
         log_print(INFO, "Received signal %d", signal);
         if (signal == SIGCHLD && waitpid(pppd_pid, &status, WNOHANG) == pppd_pid
-            && WIFEXITED(status)) {
+                && WIFEXITED(status)) {
             status = WEXITSTATUS(status);
             log_print(INFO, "Pppd is terminated (status = %d)", status);
             status += PPPD_EXITED;
@@ -256,7 +256,7 @@
     error = getaddrinfo(server, port, &hints, &records);
     if (error) {
         log_print(FATAL, "Getaddrinfo() %s", (error == EAI_SYSTEM) ?
-                  strerror(errno) : gai_strerror(error));
+                strerror(errno) : gai_strerror(error));
         exit(NETWORK_ERROR);
     }