commit 438403eab51611bd92050e64eba56efe00c613da
author Tom Taylor <tomtaylor@google.com> Thu Feb 21 16:56:01 2013 -0800
committer Tom Taylor <tomtaylor@google.com> Thu Feb 21 16:56:01 2013 -0800
tree c70116ae783de87070017de6331b609d9a6e5fe7
parent bf925845027f471ead845417ded90686c836cac4

Don't allow clients to update or insert _data column data

Bug 8214355

Change-Id: I45c93047ced465277a46c6a33d6ef590ab0bf8bb

src/com/android/providers/telephony/MmsProvider.java

diff --git a/src/com/android/providers/telephony/MmsProvider.java b/src/com/android/providers/telephony/MmsProvider.java
index a7e4ed4..ac7c1f9 100644
--- a/src/com/android/providers/telephony/MmsProvider.java
+++ b/src/com/android/providers/telephony/MmsProvider.java
@@ -268,6 +268,10 @@
 
     @Override
     public Uri insert(Uri uri, ContentValues values) {
+        // Don't let anyone insert anything with the _data column
+        if (values != null && values.containsKey(Part._DATA)) {
+            return null;
+        }
         int msgBox = Mms.MESSAGE_BOX_ALL;
         boolean notify = true;
 
@@ -682,6 +686,10 @@
     @Override
     public int update(Uri uri, ContentValues values,
             String selection, String[] selectionArgs) {
+        // Don't let anyone update the _data column
+        if (values != null && values.containsKey(Part._DATA)) {
+            return 0;
+        }
         int match = sURLMatcher.match(uri);
         if (LOCAL_LOGV) {
             Log.v(TAG, "Update uri=" + uri + ", match=" + match);